/meta/ - Board Meta

[Make a Post]
[X]






Broken external links Nanonymous No.6756 [D][S][L][A][C]
I've noticed site links get broken if they contain parens. Maybe other symbols are affected too.

https://en.wikipedia.org/wiki/Engine_efficiency#Gasoline_(petrol)_engines

https://en.wikipedia.org/wiki/Engine_efficiency#Gasoline_%28petrol%29_engines

Nanonymous No.6757 [D]
The missing symbols seemed to be [, ], @,$, ', (, ), and * according to https://stackoverflow.com/questions/7109143/what-characters-are-valid-in-a-url
The problem is with the second to last gsub in post.nano2html

Nanonymous No.6758 [D]
I pointed them out to hakase a long time ago, and only certain characters like # and ! got added while the others were omitted for the given reason of allowing stuff like (http://example.com) to be possible.

Nanonymous No.6781 [D]
all valid symbols can now be linkified in an html string, but if anyone has any ideas on how to pattern match out &xx; characters in stuff like 'http://1.23' "http://1.23" and <http://1.23> with lua, let me know

Nanonymous No.6782 [D]
Actually, it's probably better to keep the brackets linkified for urls like https://en.wikipedia.org/wiki/Engine_efficiency#Gasoline_(petrol) . I'll leave it be for now though

Nanonymous No.6783 [D][U][F] >>6785
File: 1fc80c1e336f467f72b9473ccf126d9d4a693afae86746614874909ef37baccc.png (dl) (98.03 KiB)
Once again, the based and redpilled ASUKAFAG(me) corrects the issue perfectly!
http://nanochangkn3dxfkr5prfw76hiq3qpjyzr44m4zxbwub5f4kditlufid.onion/pico/test/5#53

Nanonymous No.6785 [D]
>>6783
Oh and, suckermoot, if you want to steal the code you can find it in the picochan 2.2 release which was made a few minutes ago.
You're welcome.